Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VLSU: fix bug related to new VLSU #3082

Merged
merged 3 commits into from
Jun 18, 2024
Merged

VLSU: fix bug related to new VLSU #3082

merged 3 commits into from
Jun 18, 2024

Conversation

Anzooooo
Copy link
Member

Fixed bugs related to vector Segment, mainly:

  • Splitptr movement logic for VSegmentUnit and added processing logic for cache bank_conflict for SegmentUnit.
  • The repeated release of redirected freelist entries in VMergeBuffer.
  • The tlb_miss signal in LoadUnit is triggered by the Segment instruction.

See the commit information for more details.

@Anzooooo
LoadUnit: fix LoadUnit tlb_miss signal that generates errors.
ead947a 
The tlb request initiated by the VSegmentUnit prodced a tlb_miss, this causes the LoadUnit to think that a tlb_miss has occurred and issue a kill signal
@Anzooooo
VMergeBuffer: fix the repeated release of redirected freelist entries.
8391a88 
Freelist that have been redirected or unallocated should not be released.
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 742f999

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
742f999 1.801 0.452 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
5adc482 1.801 0.452 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
0d257fb 1.801 0.452 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
ba5ba1d 1.805 0.452 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
6613a2d 1.801 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
9810c04 1.805 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
0184a80 1.803 0.448 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
8fe4f15 1.805 0.448 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
54cc3a0 1.805 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
26c1abd 1.803 0.448 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
fd3aa05 1.803 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932

@Anzooooo
VLSU: fixed Splitptr calculation errors in VSegmentUnit and added pro…
c405846 
…cessing logic for cache bank_conflict for SegmentUnit.
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: c405846

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
c405846 1.801 0.452 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
5adc482 1.801 0.452 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
0d257fb 1.801 0.452 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
ba5ba1d 1.805 0.452 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
6613a2d 1.801 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
9810c04 1.805 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
0184a80 1.803 0.448 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
8fe4f15 1.805 0.448 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
54cc3a0 1.805 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
26c1abd 1.803 0.448 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
fd3aa05 1.803 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932

@Anzooooo Anzooooo requested a review from linjuanZ June 18, 2024 02:33
@Tang-Haojin Tang-Haojin merged commit 69a3c27 into master Jun 18, 2024
6 checks passed
@Tang-Haojin Tang-Haojin deleted the wzz-fix-new-vlsu-00 branch June 18, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linjuanZ linjuanZ linjuanZ approved these changes

@weidingliu weidingliu weidingliu approved these changes

@good-circle good-circle Awaiting requested review from good-circle good-circle is a code owner

@cz4e cz4e Awaiting requested review from cz4e cz4e is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Anzooooo @XiangShanRobot @linjuanZ @weidingliu @Tang-Haojin