New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed/unsigned configuration values #1324

Open
jano42 opened this Issue Sep 25, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@jano42

jano42 commented Sep 25, 2017

I've facing a problem with a Fibaro Wall Plug (config\fibaro\fgwpe.xml)

The config parameter "Oveload safety switch" is declared as short type, with a default value of 65535 !

As implied by ZWave spec, vlaues are signed, so the values should be in range [-32766;+32767]

Finally, in software we don't really have a mean to determine which type is to use (signed or unsigned).

I've looked in some other config files from other manufacturers, and found many other discrepancies

  • config\aeotec\dsc06106.xml ("Blinking behavior" min="0" max="65535")
  • config\devolo\rs014G0159.xml ("Led Flash Period" min="0" max="65535")
  • config\horstmann\sir321.xml ("Temperature reporting intervals" min="0" max="65534")
  • and many others

Which is the best way to determine the right type ?

  • using the min/max/default values (if value is > 32767, then => unsigned value). So our software make the decision
  • a better behavior would be to have an Openzwave method which tell the signed/unsigned state

This issue is regularly the subject #229 ,...

Thanks

@Fishwaldo

This comment has been minimized.

Member

Fishwaldo commented Dec 12, 2017

We only support unsigned values currently. With the release of the Spec, we now know that only the Configuration CC supports signed/unsigned values. (version 3 and above). To fix that, we either need to add some signed ValueID's, or some kind of flag to existing values. Putting this on a Todo list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment