Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
ForceInstances enabled by default in Dev branch #1450
I'm using the Dev branch and I have some issues with a Fibaro Motion Sensor, most Values are not updated.
The problem is that m_alwaysSetInstance = true in my situation, but it should be false, as the ForceInstances setting in the XML file of my node is not set. However the constructor of the MultiChannelAssociation sets it to true by default, and ReadXML sets it to false only if ForceInstances != "false" (which seems weird).
Apparently the logic of this setting was completely reversed by this commit: a5305f0#diff-26e3ab0b3f23a933a6a8580802da0a34
If I revert the changes to the MultiChannelAssociation.cpp file, I can fix the associations on my Fibaro Motion Sensor and then all values are correctly updated.
This change seems obviously wrong to me, and I wonder why it was introduced in this commit about the CentralScene CC.
The change was made as Instance Based Associations should be the default moving forward. Hence why its "opposite" from the master branch. (but a breaking change, so not ported there).
We probably need to update the config files where forceInstances is enabled to remove that line (and only use forceInstances="false" on devices that don't support instance based associations)
If you revert the changes - Is its instance based association, or the old Node Based Association?
I don't see what the benefits of forcing the instance by default are, but If you want to disable it by setting ForceInstances="false", this line in MultiChannelAssociation::ReadXML is incorrect:
I'm not sure I understand your question. I haven't changed the code in MultiChannelAssociation::Set, and so with _instance set to 0, this is what is sent:
The instance doesn't appear in the message sent, and considering SDS13782 Z-Wave Management Command Class Specification, I would say it is an old non multi-channel association.
Looking back, the behavior of my FGMS001-ZW5 Motion Sensor (manufacturer id 0x010f / product id 0x1001) was actually kind of weird when the associations were set with instance = 1. If I remember correctly, I did receive the motion sensors events, but not the temperature reports (I don't think those are supposed to be influenced by association groups). I will have to test to confirm this.
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.