New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused-private-field on FreeBSD 11.2 #1626

Closed
Wraul opened this Issue Oct 13, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@Wraul

Wraul commented Oct 13, 2018

CFLAGS += -Wno-unused-private-field

For MacOS Mojave you appear to be setting -Wno-unused-private-field.
I believe this is needed for FreeBSD 11.2 too, See OpenZWave/python-openzwave#137
I have not tried it on any other versin than 11.2 so I don't know for sure if it is limited to that version.

As I mentioned in the linked issue I think it might be fixed by #1580. But seeing the CFLAG for Mojave I'm not sure if #1580 is your preferred solution.

@Fishwaldo

This comment has been minimized.

Member

Fishwaldo commented Oct 22, 2018

I prefer to fix the code that add a workaround that hides the issue. This should be fixed in the code.

I've just removed that flag in commit dd40388 as that slipped through

@Fishwaldo Fishwaldo closed this Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment