Skip to content

fix(bench): regenerate anvil state dump and pin anvil version in CI #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xNeshi merged 4 commits into from
May 13, 2026
Merged

fix(bench): regenerate anvil state dump and pin anvil version in CI #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ee84be
fix(bench): regenerate anvil state dump and pin anvil version in CI
0xNeshi May 4, 2026
49f7677
Potential fix for pull request finding
0xNeshi May 4, 2026
3704c9f
Merge branch 'main' into fix-bench-dump
0xNeshi May 6, 2026
cbf63aa
Merge branch 'main' into fix-bench-dump
0xNeshi May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/base_benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ jobs:

- name: Setup Foundry
uses: foundry-rs/foundry-toolchain@c7450ba673e133f5ee30098b3b54f444d3a2ca2d # v1.8.0
with:
# Pin to the anvil version used to generate benches/dumps/state_*.json.gz
# (see anvil_version in benches/dumps/state_*.metadata.json). Anvil's
# state-dump JSON is not version-compatible: loading a dump with a
# different version fails with SerializableTransactionType / missing
# field errors. Bump this together with the regenerated dump files.
version: v1.7.0
Comment thread
0xNeshi marked this conversation as resolved.

- name: Setup Bencher
# Official docs recommend using `main` commit, because discrepancies between CI version and Bencher's API version
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/pr_benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,13 @@ jobs:

- name: Setup Foundry
uses: foundry-rs/foundry-toolchain@c7450ba673e133f5ee30098b3b54f444d3a2ca2d # v1.8.0
with:
# Pin to the anvil version used to generate benches/dumps/state_*.json.gz
# (see anvil_version in benches/dumps/state_*.metadata.json). Anvil's
# state-dump JSON is not version-compatible: loading a dump with a
# different version fails with SerializableTransactionType / missing
# field errors. Bump this together with the regenerated dump files.
version: v1.7.0
Comment thread
0xNeshi marked this conversation as resolved.

- name: Setup Bencher
# Official docs recommend using `main` commit, because discrepancies between CI version and Bencher's API version
Expand Down
7 changes: 6 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ flate2 = { version = "1.1", optional = true }
tracing = { version = "0.1", optional = true }

[dev-dependencies]
alloy = { version = "1.1.2", features = ["node-bindings", "provider-ws", "rpc-types-anvil"] }
alloy = { version = "1.1.2", features = [
"node-bindings",
"provider-ws",
"rpc-types-anvil",
] }
criterion = { version = "0.8", features = ["async_tokio", "html_reports"] }
tracing-subscriber = { version = "0.3", features = ["fmt", "env-filter"] }
test-log = { version = "0.2.18", features = ["trace"] }
Expand Down Expand Up @@ -108,6 +112,7 @@ bench-utils = [
"dep:flate2",
"dep:tracing",
"alloy/node-bindings",
"alloy/provider-ws", # needed when running `cargo run --bin generate_dump --features bench-utils`
]
example = ["tracing", "dep:anyhow"]
http-subscription = ["robust-provider/http-subscription"]
Expand Down
Binary file modified benches/dumps/state_100000.json.gz
View file
Open in desktop
Binary file not shown.
6 changes: 3 additions & 3 deletions benches/dumps/state_100000.metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"event_count": 100000,
"contract_address": "0x5fbdb2315678afecb367f032d93f642f64180aa3",
"block_number": 3298,
"generation_time_secs": 32.816945,
"anvil_version": "anvil Version: 1.5.1-stable\nCommit SHA: b0a9dd9ceda36f63e2326ce530c10e6916f4b8a2\nBuild Timestamp: 2025-12-22T11:41:09.812070000Z (1766403669)\nBuild Profile: maxperf"
"block_number": 28263,
"generation_time_secs": 282.780018286,
"anvil_version": "anvil Version: 1.6.0-v1.7.0\nCommit SHA: f83bad912a9dba7bf0371def1e70bb1896048356\nBuild Timestamp: 2026-04-28T14:07:10.568929921Z (1777385230)\nBuild Profile: dist"
}
Loading