Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finalize_keccak to is_valid_eth_signature #542

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

andrew-fleming
Copy link
Collaborator

@andrew-fleming andrew-fleming commented Jan 16, 2023

This was missing from EthAccount's signature validation. There is no immediate risk. A security advisory is incoming.

Note:
EthAccount signed tx on goerli at: 0x3a88b437686cd2e3dc73fdc3c65ddf3dc5a96b3eb327b6140e9eb64485119db

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrew-fleming andrew-fleming merged commit 8d5c0b4 into OpenZeppelin:main Jan 16, 2023
@andrew-fleming andrew-fleming deleted the fix-eth-account branch January 16, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants