Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves Ownable events #1397

Merged
merged 21 commits into from Oct 9, 2018

Conversation

@Aniket-Engg
Copy link
Contributor

commented Oct 8, 2018

Fixes #1392

@nventuro

This comment has been minimized.

Copy link
Member

commented Oct 8, 2018

Thanks a lot @Aniket-Engg!

Looks like the Ownable tests don't currently check for events 😱 Could you add those checks to this PR? The constructor one we can skip for now though, since that one is somewhat tricky (#1354 has the same problem).

@Aniket-Engg

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2018

okay @nventuro . I also saw that issue and was not sure for constructor event.

Copy link
Member

left a comment

Another great PR @Aniket-Engg, thanks a lot!

@nventuro nventuro merged commit af42c39 into OpenZeppelin:master Oct 9, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
nventuro added a commit to nventuro/openzeppelin-contracts that referenced this pull request Oct 18, 2018
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (OpenZeppelin#1359)"

This reverts commit a688977.

* updates

* fixes OpenZeppelin#1392

* event tests added

* constructor event added

(cherry picked from commit af42c39)
elopio added a commit that referenced this pull request Oct 21, 2018
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* updates

* fixes #1392

* event tests added

* constructor event added

(cherry picked from commit af42c39)
colltoaction added a commit to rsksmart/openzeppelin-solidity that referenced this pull request Nov 26, 2018
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (OpenZeppelin#1359)"

This reverts commit a688977.

* updates

* fixes OpenZeppelin#1392

* event tests added

* constructor event added

(cherry picked from commit af42c39)
@Aniket-Engg Aniket-Engg deleted the Aniket-Engg:fix/#1392 branch Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.