Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refundable post delivery crowdsale #1543

Merged

Conversation

@nventuro
Copy link
Member

commented Dec 6, 2018

Fixes #877

Since this is a PostDeliveryCrowdsale, tokens will only be granted after it ends, and only if the crowdsale is successful (i.e. the goal is met): therefore, the tokens being issued and purchases being refunded become mutually exclusive scenarios, preventing the issue described.

I made the new crowdsale inherit from RefundableCrowdsale, but if we chose to deprecate it (i.e. pragma deprecated or something along those lines) we will probably want to copy the logic into this new contract.

@nventuro nventuro added this to the v2.1 milestone Dec 6, 2018

@nventuro nventuro self-assigned this Dec 6, 2018

@nventuro nventuro requested a review from frangio Dec 6, 2018

@frangio
Copy link
Member

left a comment

Some minor comments.

@frangio

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

In this PR we should also add the warning (the "deprecation warning") in RefundableCrowdsale.

@nventuro nventuro requested a review from frangio Dec 11, 2018

@frangio
Copy link
Member

left a comment

LGTM

@frangio frangio merged commit 357fded into OpenZeppelin:master Dec 11, 2018

2 checks passed

Travis CI - Pull Request Build Passed
Details
coverage/coveralls First build on refundable-post-delivery-crowdsale at 100.0%
Details

@nventuro nventuro deleted the nventuro:refundable-post-delivery-crowdsale branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.