Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excessive condition from SafeMath.safeAdd() #190

Merged
merged 1 commit into from Apr 12, 2017

Conversation

@lastperson
Copy link
Contributor

commented Apr 12, 2017

There is no situation when c>=a will be true while c>=b will be false.

Remove excessive condition from SafeMath.safeAdd()
There is no situation when `c>=a` will be `true` while `c>=b` will be `false`.
@maraoz

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2017

LGTM. Can someone else think up the math and ACK this before I merge it, just in case?

@federicobond

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2017

LGTM

@maraoz

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2017

Thanks @federicobond

@maraoz maraoz merged commit 70a4395 into OpenZeppelin:master Apr 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Bassel85 pushed a commit to Bassel85/ico that referenced this pull request Jul 24, 2017

SafeMathLib: Remove excessive condition from SafeMathLib's plus function
"There is no situation when c>=a will be true while c>=b will be false."
(OpenZeppelin/openzeppelin-contracts#190)

ProphetDaniel pushed a commit to classicdelta/Smart-Contracts that referenced this pull request Mar 9, 2018

Merge pull request OpenZeppelin#190 from lastperson/patch-1
Remove excessive condition from SafeMath.safeAdd()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.