Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Strings.fromUint256 to Strings.toString #2188

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Rename Strings.fromUint256 to Strings.toString #2188

merged 3 commits into from
Apr 15, 2020

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Apr 15, 2020

Fixes #2156

@frangio frangio requested a review from nventuro April 15, 2020 19:04
nventuro
nventuro approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nventuro nventuro merged commit 8b10cb3 into OpenZeppelin:master Apr 15, 2020
@frangio frangio deleted the strings-to-string branch April 15, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventuro nventuro nventuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

utils/String fromUint256 should probably be toString
2 participants
@frangio @nventuro