-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid storing hashing function pointers in storage make MerkleTree structure upgrade-safe #5080
Avoid storing hashing function pointers in storage make MerkleTree structure upgrade-safe #5080
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expanded a bit on the documentation, I felt we needed to give an official recommendation of how to store the function as it may seem pretty easy to just put it in storage as we were doing.
Also, I added cross-references where possible but the custom setup
and push
can't be referenced since adding two -
(hyphens) gets encoded as —%E2%80%8B
and can't find where the issue is (likely in https://github.com/OpenZeppelin/solidity-docgen/)
LGTM
Fixes #5079
This is change to an unreleased feature, no need for a changeset entry.
PR Checklist