New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show log password field for attended logs (Bug #1191) #719

Merged
merged 1 commit into from Jul 9, 2018

Conversation

Projects
None yet
2 participants
@sdennler
Copy link
Contributor

sdennler commented Jul 5, 2018

1. Why is this change necessary?

On the log page, when selecting a "attended" log to log a Event cache whit password the password field didn't show up.

2. What does this change do, exactly?

Show the password field for both "attended" and "found" logs.

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

https://redmine.opencaching.de/issues/1191

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 5, 2018

Codecov Report

Merging #719 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           development    #719   +/-   ##
===========================================
  Coverage         5.44%   5.44%           
===========================================
  Files              259     259           
  Lines            16056   16056           
===========================================
  Hits               874     874           
  Misses           15182   15182

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff940ae...aa5f29c. Read the comment docs.

@teiling88 teiling88 merged commit 37571a0 into OpencachingDeutschland:development Jul 9, 2018

3 checks passed

Scrutinizer 3 new issues
Details
codecov/project 5.44% remains the same compared to ff940ae
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@teiling88

This comment has been minimized.

Copy link
Member

teiling88 commented Jul 9, 2018

Thanks for your contribution. It is already deployed on production :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment