Skip to content

refactor (translations) add ja, sv, pt, nl, zh, dk; refactor es, it, de #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 12, 2020
Merged

refactor (translations) add ja, sv, pt, nl, zh, dk; refactor es, it, de #36

merged 6 commits into from
Jun 12, 2020

Conversation

@potench
Copy link

@potench potench commented Jun 9, 2020 •
edited
Loading

background

  • add translations for ja, sv, pt, nl, zh
  • refactor translations for es, it
  • add flag to swap locale in reference page easily
  • add "features" translations
  • break up localization files
  • optimize "features" section with purposes section

test plan

yarn dev
# browse to http://localhost:8080/reference.html?forceLocale=zh 
# change forceLocale to any of the new translation codes

potench
potench commented Jun 10, 2020
View reviewed changes
src/lib/translations/de.js
features: {
menu: 'Funktionen',
},
footer: {
Copy link
Author

@potench potench Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for translation of this for de, pl, and fr

@potench potench changed the title refactor (translations) add ja, sv, pt, nl, zh; refactor es, it refactor (translations) add ja, sv, pt, nl, zh, dk; refactor es, it, de Jun 12, 2020
@potench potench merged commit 0252f10 into master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maskachka maskachka maskachka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@potench @maskachka