-
Notifications
You must be signed in to change notification settings - Fork 0
Pfe 4216 #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pfe 4216 #51
Conversation
mode, removes condtional navigation logic for vendors layer
close with x button that accepts all and background color override support
| maxHeight: maxHeightModal, | ||
| }} | ||
| > | ||
| { showCloseX && <div class={style.closeX} onClick={this.handleAcceptAll}>×</div>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checking with product on this, think compliance didn't want close button to accept all originally but that mighta changed
| maxHeight: maxHeightModal, | ||
| }} | ||
| > | ||
| { shouldShowCloseX && <div class={style.closeX} onClick={this.handleAcceptAll}>×</div>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change this so we can track when user clicks "Close" vs "acceptAll" will be good to see telemetry on that.
onClick={this.handleClose}
// ....
// further up
handleClose = () => {
this.handleAcceptAll('acceptAllClose');
}
handleAcceptAll = (clickCategoty = 'acceptAll') => {
// change logger click category
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added these to the 3 banners.
potench
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Background
Test Plan
Go to http://localhost:8080/tcf-2.0.html