Skip to content

Conversation

@potench
Copy link

@potench potench commented Feb 26, 2021

Background

Implements disclosures for cookieMaxAgeSeconds based on this amendment: https://iabeurope.eu/wp-content/uploads/2020/08/TCF_V-CMP_comms_AmendmentsToTCFv2.0PoliciesAndTechnicalSpecificationsToRequireDisclosureOfStorageDurationPlanet49-ruling_190820_IABEurope-converted.pdf

  • Updates to GVL 79
  • Improve legibility on Purposes List legal disclaimers ("\n" was not inserting a new line)
  • Implement cookieMaxAgeSeconds Device Storage disclosers in Vendors List
  • Refactor error logger so we don't need to manage onerror overrides.

Test Plan

yarn run
# browse to http://localhost:8080/tcf-2.0.html
# click on "Our Partners" 
# click on a vendor and scroll down to the Device Storage disclosure

Screen Shot 2021-02-26 at 9 15 39 AM

Screen Shot 2021-02-26 at 9 03 02 AM

Error Logger Verification:
Screen Shot 2021-02-26 at 9 32 11 AM

Copy link

@imartinez8 imartinez8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except I think indentation might be off? Seems like really big indentations

@potench
Copy link
Author

potench commented Feb 26, 2021

LGTM except I think indentation might be off? Seems like really big indentations

Yeah - there's a really big render block with lots of ternaries and nested elements. Was thinking it's about time to break it up.

Copy link

@benstrahan benstrahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

};
global.addEventListener('error', errorLoggerListener, false);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@potench potench merged commit 6469d83 into master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants