refactor (cmp: inline) inline version of CMP #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat
Render the CMP inline to a target DOM insertion node.
config.theme.isBannerInlineenables relative positioning mode so the CMP can render within your main layout instead of layering it as a modal.config.insertionNodeto identify a DOM node to insert CMPOther Fixes
Test Plan
Testing
inlineMode.Use The Sandbox to test
inlineMode,slimMode, and other features.Live sandbox link
Testing theme colors
Sandbox is using custom colors, you can see anchors within translated text now get theme colors applied
https://www.loom.com/share/eb274721ae094eda8a879d8b7144aa6c