Skip to content

fix (cmp: showConsent) only show consent modal automatically if gdprApplies #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 29, 2021
Merged

fix (cmp: showConsent) only show consent modal automatically if gdprApplies #59

merged 4 commits into from
Sep 29, 2021

Conversation

@potench
Copy link

@potench potench commented Sep 29, 2021 •
edited
Loading

Background

The CMP assumed users want to automatically show the Modal after initialization.

  • Provideconfig.shouldAutoShowModal: false to allow override of behavior that auto shows the modal
  • upgrade global vendors

test plan

npm run dev 
# browse to http://localhost:3030/tcf-2.0.html?autoshowmodal=false
# toggle the "Auto Show Modal" checkbox to test

@potench potench merged commit f6dae41 into main Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@potench