refactor(components, app): move StyledText from app to components #14715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move StyledText from app to components for Chip component unification. close AUTH-228
jerader
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
nice! I did some smoke testing in app/odd/storybook and things look good. Once this merges, I think you should post it in the app and ui channel so all frontend devs are aware. This refactor also means that PD can use StyledText instead of having its own version, so that's awesome.
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
…4715) * refactor(components, app): move StyledText from app to components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
move
StyledTextfrom app to components for Chip component update+unification.https://opentrons.slack.com/archives/C06M6R72UDS/p1710857517041999?thread_ts=1710857252.462119&cid=C06M6R72UDS
Chip component uses
StyledTextand components has been released as a npm package.close AUTH-228
Test Plan
Changelog
Review requests
Risk assessment
mid since this PR updated 389 files