This repository has been archived by the owner on Sep 4, 2018. It is now read-only.
Fix notification when signing up (or really any flash) #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 24, 2017
| top: $navbar-height; | ||
| position: fixed; | ||
| left: 50%; | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| @@ -92,17 +94,21 @@ i.fa.medium { | |||
| padding-left: 3%; | |||
| } | |||
|
|
|||
|
|
|||
| #alert-section { | |||
| z-index: 997; | |||
There was a problem hiding this comment.
Properties should be ordered left, position, top, z-index
| @@ -92,17 +94,21 @@ i.fa.medium { | |||
| padding-left: 3%; | |||
| } | |||
|
|
|||
|
|
|||
| #alert-section { | |||
|
Very nice fix! 👍 |
|
I know there is some work for changing signup to have a landing page (#635), but I think this will still be useful for anytime |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one possible fix for #646
Another problem I observed is when there are multiple alerts on a page (by having, say, both
flash[:notice]andflash[:error]). The.alertstyle uses a z-axis, so the multiple alerts would be positioned on top of each other, and all but the first would be hidden.This PR solves both by putting the alerts into it's own
section(but I guess it could have been acontainertoo). This allows the section to be positioned (with z axis, offset from the top), and multiple alerts can go inside