From 7bca94ef8c10668ff0870b2cefb7752ff92cc43b Mon Sep 17 00:00:00 2001
From: David Byron <82477955+dbyron-sf@users.noreply.github.com>
Date: Tue, 21 Mar 2023 19:16:59 -0700
Subject: [PATCH] fix(manifests/test): add
 org.junit.jupiter:junit-jupiter-engine as a test runtime dependency (#963)

* chore(manifests): remove testImplementation org.junit.vintage:junit-vintage-engine dependency

as it's not needed at test compile time, and since build.gradle supplies a test runtime dependency as of https://github.com/spinnaker/rosco/pull/958

* fix(manifests/test): add org.junit.jupiter:junit-jupiter-engine as a test runtime dependency

so junit5 tests run.  Before this PR, 9 tests ran in rosco-manifests, all spock tests.
After this PR, 32 tests run.

Note that spring-boot-starter-test brings in org.junit.jupiter:junit-jupiter-engine so
where that's used, we don't need to declare junit-jupiter-engine explicitly.  Note also
that rosco-core currently only has spock tests, so although it doesn't use
spring-boot-starter-test, it doesn't need org.junit.jupiter:junit-jupiter-engine either.
---
 rosco-manifests/rosco-manifests.gradle | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rosco-manifests/rosco-manifests.gradle b/rosco-manifests/rosco-manifests.gradle
index 7d345b4f7..7cb8e23ed 100644
--- a/rosco-manifests/rosco-manifests.gradle
+++ b/rosco-manifests/rosco-manifests.gradle
@@ -19,7 +19,6 @@ dependencies {
   testImplementation "org.junit.jupiter:junit-jupiter-api"
   testImplementation "org.junit.jupiter:junit-jupiter-params"
   testImplementation "org.junit.platform:junit-platform-runner"
-  testImplementation "org.junit.vintage:junit-vintage-engine"
   testImplementation "org.mockito:mockito-core"
   //testImplementation "org.spockframework:spock-core"
   //api(platform("org.spockframework:spock-bom:2.4-M1-groovy-4.0"))
@@ -27,4 +26,5 @@ dependencies {
   implementation("jakarta.annotation:jakarta.annotation-api:2.1.1")
   testImplementation("jakarta.annotation:jakarta.annotation-api:2.1.1")
 
+  testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine"
 }