Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the lazy client error handler on close #1605

Merged

Conversation

lavarsicious
Copy link
Contributor

@lavarsicious lavarsicious commented Jan 3, 2020

The lazy client error event handler is never unregistered when the queue is closed. This becomes more problematic in a scenario in which options.createClient is specified.

@lavarsicious lavarsicious changed the title Remove the lazy client error handler on close fix: Remove the lazy client error handler on close Jan 3, 2020
@coveralls
Copy link

coveralls commented Jan 3, 2020

Coverage Status

Coverage increased (+0.04%) to 93.8% when pulling faa1dc7 on lavarsicious:remove-client-error-listener into 081b37f on OptimalBits:develop.

@lavarsicious lavarsicious force-pushed the remove-client-error-listener branch from 3b7b78d to faa1dc7 Compare Jan 9, 2020
@gabegorelick
Copy link
Contributor

gabegorelick commented Feb 14, 2020

@lavarsicious Are you able to add a test for this?

@manast manast merged commit 626f21f into OptimalBits:develop Mar 21, 2020
2 checks passed
jtassin pushed a commit to jtassin/bull that referenced this pull request Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants