Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs in requirements.txt since previous one can cause errors #697

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

xu1868
Copy link
Contributor

@xu1868 xu1868 commented Feb 3, 2024

Hello!

In transformers 4.35.0, the developers deleted names is_fairscale_available and default_hp_search_backend from transformers.integrations, which causes errors since LMFlow actively tries to find the names in those locations.

As a quick workaround, I propose to change the requirements.txt and add a condition transformers<4.35.0.

@shizhediao
Copy link
Contributor

LGTM. Thanks!

@shizhediao shizhediao closed this Feb 9, 2024
@shizhediao shizhediao reopened this Feb 9, 2024
Copy link
Contributor

@shizhediao shizhediao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shizhediao shizhediao merged commit 0e9a9a6 into OptimalScale:main Feb 9, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants