Rewrite backup system - #1299
Merged
OverloadedOrama merged 6 commits intoJul 9, 2025
Merged
Conversation
OverloadedOrama
approved these changes
Jul 9, 2025
OverloadedOrama
left a comment
OverloadedOrama
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thank you!
OverloadedOrama
added a commit
that referenced
this pull request
Jul 15, 2025
Leftover line from #1299
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new system keeps backups of upto 20 last sessions (older session backups get removed)
This is basically the LifeSaver extension, integrated to core.
(some other related fixes i found while integrating):
Global.popup_error(tr("File failed to save. Error code %s (%s)") % [err, error_string(err)])accidentally placed after return instead of before."user://backups"to a single variable (which should be less prone to bugs)