Fix potential index out of bounds error #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OverloadedOrama
approved these changes
Jan 30, 2021
|
Oh you are right. I tested the GitHub Actions generated build first which doesn't crash and I thought the issue was fixed, my bad. Anyway, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
OpenSave.reload_backup_fileafter the first removal withproject_paths.remove(backup_paths.find(backup))the index returned bybackup_paths.find(backup)will no longer point to the project path respective to thatbackup,project_pathsandbackup_pathsarrays would be "desynchronized". This PR makes both arrays be changed properly when iterating over the backup paths (and shrinked if needed after the loop).