New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ssdp serde #28

Merged
merged 2 commits into from Jul 17, 2017

Conversation

Projects
None yet
2 participants
@andete

andete commented Jul 17, 2017

No description provided.

@LFalch

This comment has been minimized.

Member

LFalch commented Jul 17, 2017

AppVeyor failed but it doesn't seem to be because of the code.

@LFalch

This comment has been minimized.

Member

LFalch commented Jul 17, 2017

Looks good!

@LFalch LFalch self-assigned this Jul 17, 2017

@LFalch LFalch added the enhancement label Jul 17, 2017

@LFalch LFalch self-requested a review Jul 17, 2017

@LFalch

LFalch approved these changes Jul 17, 2017

@LFalch LFalch merged commit efbb4d9 into Orangenosecom:master Jul 17, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@andete andete deleted the rustit-be:update_ssdp_serde branch Jul 18, 2017

@LFalch

This comment has been minimized.

Member

LFalch commented Aug 13, 2017

Bridge::get_all_groups seems to have broken because of this. I cannot tell why. @andete

@andete

This comment has been minimized.

andete commented Aug 13, 2017

Hmm, maybe serde changed how deserializing into a BTreeMap is done?
My https://github.com/andete/hue_persistence app is still working fine.
Latest hue_persistance uses my latest fork using hyper 0.11/Futures here though to be able to add a timeout to the hue request.
https://github.com/andete/philipshue/tree/hyper_0.11

@LFalch

This comment has been minimized.

Member

LFalch commented Aug 13, 2017

I seem to have found a fix. Apparently deserialising a list of strings to a Vec<usize> doesn't work anymore. So I had to make a function for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment