Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tabs from test cases to make them work #148

Merged
merged 1 commit into from Apr 24, 2016
Merged

Remove tabs from test cases to make them work #148

merged 1 commit into from Apr 24, 2016

Conversation

ghedo
Copy link
Contributor

@ghedo ghedo commented Apr 24, 2016

They would otherwise fail.

@Orc
Copy link
Owner

Orc commented Apr 24, 2016

How are the test cases failing?

As a general rule, my reaction to a test case failing is not to change the test case, but to see what changed in discount to make it start failing.

@Orc Orc closed this Apr 24, 2016
@ghedo
Copy link
Contributor Author

ghedo commented Apr 24, 2016

This is the errors I get:

data corruption cases from Fernando Muñoz ............
id_000040_06
source:
    <dl></d
        >00000
diff:
    2c2
    <         >00000</p>
    ---
    >     >00000</p>

id_000152_06
source:
    <p></
        >00000
diff:
    2c2
    <         >00000</p>
    ---
    >     >00000</p>

id_000163_06
source:
    <div></di
        >00000
diff:
    2c2
    <         >00000</p>
    ---
    >     >00000</p>

id_000167_06
source:
    <div </di
        >00000
diff:
    2c2
    <         >00000</p>
    ---
    >     >00000</p>

id_000223_06
source:
    <!--
        -->00000
diff:
    2c2
    <         -->00000</p>
    ---
    >     -->00000</p>

tests/muñoz.t: 70 tests; 5 failed/65 passed

Makefile:106: recipe for target 'test' failed
make: *** [test] Error 1

maybe the tabs are interpreted differently?

@Orc
Copy link
Owner

Orc commented Apr 24, 2016

How did you configure your version of discount when you built it?

@ghedo
Copy link
Contributor Author

ghedo commented Apr 24, 2016

I can reproduce by just running configure.sh without any arguments.

@Orc
Copy link
Owner

Orc commented Apr 24, 2016

Okay, that's bizarre; I built discount w/o any arguments and couldn't reproduce the failure.

Does it not fail for you when you configure --with-tabstops ?

@Orc
Copy link
Owner

Orc commented Apr 24, 2016

Okay, oddness; there's a dependency failure in the build; I don't reproduce the failure if I ./configure.sh;make test, but I do if I make distclean;./configure.sh;make test.

@Orc Orc reopened this Apr 24, 2016
@Orc Orc merged commit d479aba into Orc:master Apr 24, 2016
@Orc Orc self-assigned this Apr 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants