Orchard.OutputCache shouldn't handle cache invalidation in the settings part handler #7958

Closed
carlwoodhouse opened this Issue Feb 1, 2018 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

carlwoodhouse commented Feb 1, 2018

At the moment the invalidation of items from orchard's output cache is handled by hooking into event's in the CacheSettingsPartHandler (https://github.com/OrchardCMS/Orchard/blob/master/src/Orchard.Web/Modules/Orchard.OutputCache/Handlers/CacheSettingsPartHandler.cs)

It would be better if these 3 events weere in a separate handler, this would make it easier to suppress these event's if doing custom stuff with cache invalidation without effecting the settingspart. Really these events have nothing to do with the settings.

Can provide a PR if considered a good idea.

@carlwoodhouse carlwoodhouse changed the title from Orchard.OutputCache shouldn't handle cache invalidation in the settings part driver to Orchard.OutputCache shouldn't handle cache invalidation in the settings part handler Feb 1, 2018

carlwoodhouse pushed a commit to carlwoodhouse/Orchard that referenced this issue Feb 1, 2018

Contributor

carlwoodhouse commented Feb 1, 2018

PR of what i'm proposing here : #7959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment