New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display correct Comments total at /Admin/Blogs. Fixes #7838. #7847

Closed
wants to merge 1 commit into
base: 1.10.x
from

Conversation

Projects
None yet
3 participants
@jchenga
Contributor

jchenga commented Sep 13, 2017

The problem was due to CommentsContainerPartDriver getting the comments for a blog post.
The fix adds a new method, GetCommentsForContainer, in CommentService that returns the comments created for the blog. The part driver then calls that method instead to calculate the number of comments for the container.

@sebastienros

This comment has been minimized.

Show comment
Hide comment
@sebastienros

sebastienros Sep 14, 2017

Member

It's a breaking change. Either you target your change on dev or you remove the new method and just use GetComments().Where(c => c.CommentedOnContainer == id); directly in the driver.

Member

sebastienros commented Sep 14, 2017

It's a breaking change. Either you target your change on dev or you remove the new method and just use GetComments().Where(c => c.CommentedOnContainer == id); directly in the driver.

@jchenga

This comment has been minimized.

Show comment
Hide comment
@jchenga

jchenga Sep 14, 2017

Contributor

@sebastienros Out of curiosity, how is the PR a breaking change?

I'll target my change on dev and create another PR.

Contributor

jchenga commented Sep 14, 2017

@sebastienros Out of curiosity, how is the PR a breaking change?

I'll target my change on dev and create another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment