Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing that Orchard.Workflows requires styles that don't exist #8201

Merged
merged 6 commits into from May 15, 2019

Conversation

Projects
None yet
2 participants
@barthamark
Copy link
Contributor

commented May 15, 2019

Fixes #7873 and #8008 .

Replaces PR #8009 where the source repository doesn't exist anymore.


manifest.DefineStyle(resourceName)
.SetUrl(filename)
.SetDependencies("WorkflowsAdmin");

This comment has been minimized.

Copy link
@BenedekFarkas

BenedekFarkas May 15, 2019

Member

Minor code styling: We can write this in one line.

manifest.DefineStyle(activityName).SetUrl(activityName.HtmlClassify()).SetDependencies("WorkflowsAdmin");
foreach (var activity in _activitiesManager.Value.GetActivities()) {
var assemblyName = activity.GetType().Assembly.GetName().Name;
var basePath = VirtualPathUtility.AppendTrailingSlash("~/Modules/" + assemblyName + "/styles/");

This comment has been minimized.

Copy link
@BenedekFarkas

BenedekFarkas May 15, 2019

Member

It's technically possible for a Theme to define Workflow activities, but we won't find them this way, because "Modules" is wired in.

@BenedekFarkas BenedekFarkas changed the title Fixing that Orchard.Workflows requires styles that not exists Fixing that Orchard.Workflows requires styles that don't exist May 15, 2019

@BenedekFarkas BenedekFarkas merged commit f66169c into OrchardCMS:dev May 15, 2019

1 check passed

license/cla All CLA requirements met.
Details

BenedekFarkas added a commit that referenced this pull request May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.