Fix bad async usage in RecipeHarvester

[deanmarcussen]

OrchardCore/src/OrchardCore/OrchardCore.Recipes.Core/Services/RecipeHarvester.cs

Line 56 in a4081ac

recipeDescriptors.AddRange(recipeFiles.Select(recipeFile => _recipeReader.GetRecipeDescriptor(path, recipeFile, _hostingEnvironment.ContentRootFileProvider).Result));

Uses .Result because it is wrapped in a Linq Select

Should be adapted to use Task.WhenAll as the recipe reader underlying is making use of json async methods.

[jtkech]

Good catch and should be named GetRecipeDescriptorAsync() with the Async suffix

Should be adapted to use Task.WhenAll

Or just a foreach loop to do an await GetRecipeDescriptorAsync() on each recipeFile

[Piedone]

"foreach loop to do an await GetRecipeDescriptorAsync()" is safer since it doesn't require thread safety.

[sebastienros]

Agreed with the looped await.