New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement FileShellSettingsConfigurationProvider #1456

Closed
sfmskywalker opened this Issue Feb 6, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@sfmskywalker
Copy link
Member

sfmskywalker commented Feb 6, 2018

Currently, FileShellSettingsConfigurationProvider uses ASP.NET Core's Configuration API to load shell settings. However, it relies on a configuration provider that reads from tenants.json. This is not the right implementation, since the Configuration API is much more general purpose, and we could just as well define tenants in appsettings.json (no need to create a configuration provider that reads from tenants.json, which has a specific scope in terms of the kinds of settings expected there).

Better would be to update FileShellSettingsConfigurationProvider such that it parses "tenants.json" directly (not via the Configuration API), and perhaps implement another shell settings provider that does use the Configuration API.

See also discussion in #1451.

@sebastienros sebastienros added this to the beta2 milestone Feb 8, 2018

@sebastienros sebastienros modified the milestones: beta2, beta3 Jun 11, 2018

@sebastienros sebastienros added the P3 label Dec 6, 2018

@sebastienros sebastienros modified the milestones: beta3, rc Dec 6, 2018

sebastienros added a commit that referenced this issue Dec 8, 2018

Adding configuration support
Fixes #2038
Fixes #1456
Fixes #825
Fixes #2051

@jtkech jtkech closed this in #2824 Jan 25, 2019

@sebastienros sebastienros modified the milestones: rc, beta3 Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment