Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate database connection before allowing a tenant to be added or setup #11822

Merged
merged 50 commits into from Aug 18, 2022

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Jun 7, 2022

@hishamco
Copy link
Member

hishamco commented Jun 7, 2022

Thanks again Mike, seems still you have a Git issue ;)

@hishamco
Copy link
Member

hishamco commented Jun 7, 2022

I may share simpler way to fix the issue, let me try it tonight

@MikeAlhayek
Copy link
Member Author

Thanks again Mike, seems still you have a Git issue ;)

Yes I see that. Please check #11825

I may share simpler way to fix the issue, let me try it tonight

Can't wait to see a simpler way.

Thank you

@Skrypt
Copy link
Contributor

Skrypt commented Jul 9, 2022

Fix conflicts by merging latest main branch.

@MikeAlhayek
Copy link
Member Author

@Skrypt done.

@MikeAlhayek MikeAlhayek requested a review from jtkech August 5, 2022 04:52
@Skrypt
Copy link
Contributor

Skrypt commented Aug 8, 2022

This one for next triage

@Skrypt Skrypt added this to the 1.5 milestone Aug 16, 2022
@MikeAlhayek MikeAlhayek changed the title Validate database prefix before allowing an admin to be added Validate database connection before allowing a tenant to be added or setup Aug 18, 2022
@sebastienros sebastienros merged commit 0905e31 into OrchardCMS:main Aug 18, 2022
@MikeAlhayek MikeAlhayek deleted the ValidateDatabasePrefix branch September 2, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants