New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate database connection before allowing a tenant to be added or setup #11822
Merged
sebastienros
merged 50 commits into
OrchardCMS:main
from
MikeAlhayek:ValidateDatabasePrefix
Aug 18, 2022
Merged
Validate database connection before allowing a tenant to be added or setup #11822
sebastienros
merged 50 commits into
OrchardCMS:main
from
MikeAlhayek:ValidateDatabasePrefix
Aug 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulling new updates
Thanks again Mike, seems still you have a Git issue ;) |
I may share simpler way to fix the issue, let me try it tonight |
Yes I see that. Please check #11825
Can't wait to see a simpler way. Thank you |
Skrypt
reviewed
Jul 9, 2022
Fix conflicts by merging latest main branch. |
@Skrypt done. |
Skrypt
reviewed
Jul 10, 2022
Skrypt
approved these changes
Jul 11, 2022
MikeAlhayek
commented
Aug 2, 2022
src/OrchardCore.Modules/OrchardCore.Tenants/Services/TenantValidator.cs
Outdated
Show resolved
Hide resolved
This one for next triage |
MikeAlhayek
changed the title
Validate database prefix before allowing an admin to be added
Validate database connection before allowing a tenant to be added or setup
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_