New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable, fixe and improve the code tab extension #2678

Merged
merged 4 commits into from Nov 14, 2018

Conversation

Projects
None yet
4 participants
@yacir
Contributor

yacir commented Nov 14, 2018

Hello! This PR includes:

  • Bump of the mkdocs to version 1+ and fixe the warnings
  • Enable the markdown_fenced_code_tabs extension and update its settings
  • Improve the code-tab.css. The new style looks like

capture d ecran 2018-11-14 a 06 09 26

Hope it helps 馃槈

@dnfclas

This comment has been minimized.

dnfclas commented Nov 14, 2018

CLA assistant check
All CLA requirements met.

@yacir yacir changed the title from Enable and fixe the code tabs extension to Enable, fixe and improve the code tab extension Nov 14, 2018

@sebastienros sebastienros requested a review from agriffard Nov 14, 2018

@agriffard

It works locally but it had been commented because ReadTheDocs returned some errors building the documentation.
The only way to know if it is fixed is actually to merge it and see what happens.

@sebastienros sebastienros merged commit 544d1b0 into OrchardCMS:dev Nov 14, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@sebastienros

This comment has been minimized.

Member

sebastienros commented Nov 14, 2018

yolo

@agriffard

This comment has been minimized.

Member

agriffard commented Nov 14, 2018

@sebastienros

This comment has been minimized.

Member

sebastienros commented Nov 14, 2018

@agriffard Let's move to Azure Websites? I create the site, what username should I add so you can do what you want with it?

@yacir

This comment has been minimized.

Contributor

yacir commented Nov 14, 2018

@agriffard this error is fixed in the 1.0.4 version of the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment