Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom Widget styles and classes with Flow #2786

Open
wants to merge 2 commits into
base: dev
from

Conversation

Projects
None yet
4 participants
@j42house
Copy link

commented Dec 4, 2018

#2742 Provide Classes and Styles fields in the FlowMetadata on a Widget for users to add custom classes and styles to the widget container.
widget-classes-styles

j42house and others added some commits Dec 4, 2018

Merge pull request #1 from OrchardCMS/dev
Update fork to the latest
@agriffard

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

I'd love to have this feature merged in dev.

@sebastienros

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

What about just limiting it to classes to prevent from have to handle attributes this way. This might get more complex in liquid templates. And might also force to make cleaner changes.

@douwinga

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2018

If it is just limited to classes, it would be nice if there was a way to add classes in the admin. Something like a global stylesheet that is stored in the database.

@sebastienros

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

@douwinga I was thinking about that, by using settings on the part definition (widget or flow?). And then we could use the vue multi-select editor to display them, but also accept custom entries (optionally)

@sebastienros

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

I assume right now we could just store it as a string[] and later improve the editor. Small steps ...

@agriffard

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

So what is the idea?
Do we ask to @j42house to only support to add classes or @douwinga do you plan to implement another feature in which you can edit the content part definition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.