Add Facebook sdk #3477

MichaelPetrinolis · 2019-04-17T15:10:50Z

Reorganize directory structure of OrchardCore.Facebook module
Integrate sdk.js
Add predefined Social Plugins as widgets with OrchardCode.Facebook.Widgets feature
Rename OrchardCore.Facebook.Core feature to OrchardCore.Facebook (might break existing sites)
Add a guide how to use the Widgets feature
Widgets defined

Like
Comments
Continue with
Chat
Quote
Save
Share

The module defines a FacebookPluginPart that is used to define the widgets. Instead we could add settings to the Liquid Part to define a predefined liquid body and an option to render alternates. Then we could use it in this and any other module that defines widgets this way

Add a filter to include FB sdk WIP on SDK settings

Adding a Guide to use the facebook widgets

Jetski5822 · 2019-04-18T08:06:12Z

Do we know what the licensing is for these libs?

MichaelPetrinolis · 2019-04-18T08:58:06Z

It seems to be like Facebook Login integration. You need a facebook developer account and accept the Facebook's terms and conditions

Copied from https://appsource.microsoft.com/en-us/product/office/WA103354412

The OrchardCore.Facebook.Widgets allows you to install certain social plugins made available by Facebook on your webpages (“Plugins”). Your use of the Plugins is subject to the Facebook Platform Policies and all other applicable terms and conditions as specified by Facebook, which terms may also include a privacy policy. You are responsible for reviewing and complying with all applicable terms specified by Facebook. OrchardCore.Facebook.Widgets is not a party to the license between you and Facebook, and its privacy statement doesn’t apply to treatment of information you may exchange with Facebook when using the Plugins. OrchardCore.Facebook.Widgets isn’t responsible for the Plugins or your use of them, any warranties or claims relating to the Plugins, or customer support for the operation of the Plugins.

agriffard · 2019-04-26T09:30:04Z

@MichaelPetrinolis Have you considered to add a Workflow activity that would allow to publish a message on a Facebook page for example?
Are you aware of which SDK permissions it would imply?
Do you know any useful .NET Core supported Facebook library ?

Similarly, it could be a nice feature to add to the Twitter module: A workflow activity to post a tweet.

MichaelPetrinolis · 2019-04-26T11:06:56Z

@agriffard nice idea! After some research, it seems that Facebook provides manage_pages and publish_pages permissions that require app review, but disallows an app to post on behalf of the user. Instead we can use the instant articles which allow the app to publish.(https://developers.facebook.com/docs/instant-articles/api#create)
Unfortunately pages do not work with application tokens, we must implement something in the admin to help and administrator to retrieve a page token for an FB user. In particular, we must get a user token, exchange it for a long lived token and then require a page token that never expires.
I don't know of any .NET Core FB lib, but if we implement such functionality we can do it without adding any dependency.

sebastienros · 2019-04-27T00:21:51Z

src/OrchardCore.Modules/OrchardCore.Facebook/ScriptsMiddleware.cs

+                }
+            }
+
+            if (script is object)


What have you done @Jetski5822

sebastienros · 2019-04-27T00:22:55Z

src/OrchardCore.Modules/OrchardCore.Facebook/Views/FacebookPluginPart.Edit.cshtml

+<fieldset class="form-group">
+    <label asp-for="Liquid">@T["Body"]</label>
+    <textarea asp-for="Liquid" rows="5" class="form-control content-preview-text"></textarea>
+    <span class="hint">@T["The body of the content item, in Liquid format."]</span>


The body of what?

sebastienros · 2019-04-27T00:24:38Z

src/OrchardCore.Modules/OrchardCore.Facebook/Widgets/Services/LiquidShapes.cs

+            templateContext.MemberAccessStrategy.Register<FacebookPluginPartViewModel>();
+            await templateContext.ContextualizeAsync(shapeDisplayContext.DisplayContext);
+
+            using (var writer = new StringWriter())


There is a helper that already does this for you, and also pools the buffers

sebastienros · 2019-04-27T00:25:51Z

We definitely need a demo, but it even has a guide, so it can't be bad

agriffard · 2019-04-29T11:32:36Z

@domonkosgabor has tried it and included screenshots here: https://orcharddojo.net/blog/this-week-in-orchard-04-26-2019

add info that tenant will be reloaded if login settings change fix issues from code review

sebastienros · 2019-06-05T01:45:21Z

src/OrchardCore.Modules/OrchardCore.Facebook/ScriptsMiddleware.cs

+                }
+            }
+
+            if (script == null)


Does it mean we don't invoke the next middleware if it's not null?

That was the intention...

sebastienros · 2019-06-05T17:30:37Z

src/OrchardCore.Modules/OrchardCore.Facebook/ScriptsMiddleware.cs

+                var settings = site.As<FacebookSettings>();
+                if (httpContext.Request.Path.Value.EndsWith("fbsdk.js"))
+                {
+                    var locale = string.IsNullOrWhiteSpace(site.Culture) ? "en_US" : site.Culture.Replace("-", "_");


This settings doesn't exist anymore. You need to use ILocalizationService and it will give you the DefaultCulture to use.
But I think you should use Globalinfo.CurrentUICulture instead.

sebastienros · 2019-06-05T17:31:08Z

src/OrchardCore.Modules/OrchardCore.Facebook/ScriptsMiddleware.cs

+                        d.getElementsByTagName('head')[0].appendChild(js);
+                    }} (document));";
+                }
+                if (httpContext.Request.Path.Value.EndsWith("fb.js"))


It should use Path.GetFilename of the url

Or the last segment

Or EndsWith("/fb.js")

sebastienros · 2019-06-05T17:32:06Z

src/OrchardCore.Modules/OrchardCore.Facebook/Startup.cs

@@ -1,28 +1,62 @@
 using Microsoft.AspNetCore.Authentication;
 using Microsoft.AspNetCore.Authentication.Facebook;
+using Microsoft.AspNetCore.Mvc;


So many new usings?

use Path.GetFileName for safer filename parsing of the url split Startup classes based on feature to reduce usings

sebastienros · 2019-06-05T19:27:06Z

src/OrchardCore.Modules/OrchardCore.Facebook/StartupLogin.cs

+
+namespace OrchardCore.Facebook
+{
+    [Feature(FacebookConstants.Features.Login)]


If it's a new feature, it should have an entry in the manifest

The new feature is the [Feature(FacebookConstants.Features.Widgets)] and has an entry in the manifest :)

The core feature contains the settings needed to integrate the FB application and register fb scripts with resource manager

The login feature registers the FB Login external provider, using the appid and secret defined in the Application (core module feature)

The Widgets feature registers most of the fb plugins as widgets and a FacebookPlugin part to extend with new/missing fb plugins as widgets

MichaelPetrinolis added 11 commits April 12, 2019 18:12

Split Login feature from Facebook feature

71871a6

Add a filter to include FB sdk WIP on SDK settings

WIP

6ed06a5

WIP on widgets

1df10a6

WIP on FB widgets

3fd5f88

Register IContentPartHandler

687d87e

WIP add middleware to serve dynamic scripts

2b95675

WIP plugins

56ad9df

Adding migration recipe

8c310cf

Adding a Guide to use the facebook widgets

Move resource manifest provider to base module feature

f1bac59

changed namespace to ResourceManifest

fc0c360

fix build error

4165720

sebastienros reviewed Apr 27, 2019

View reviewed changes

moved facebook menu to first level

adc3cf8

add info that tenant will be reloaded if login settings change fix issues from code review

sebastienros reviewed Jun 5, 2019

View reviewed changes

use CurrentUICulture to get culture

24da3bd

use Path.GetFileName for safer filename parsing of the url split Startup classes based on feature to reduce usings

sebastienros reviewed Jun 5, 2019

View reviewed changes

sebastienros merged commit 249043c into OrchardCMS:dev Jun 5, 2019

sebastienros deleted the facebook_sdk branch June 5, 2019 21:21

scleaver pushed a commit to scleaver/OrchardCore that referenced this pull request Aug 22, 2019

Add Facebook sdk (OrchardCMS#3477)

13db859

MatthijsKrempel pushed a commit to MatthijsKrempel/OrchardCore that referenced this pull request Dec 23, 2019

Add Facebook sdk (OrchardCMS#3477)

8b225d0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Facebook sdk #3477

Add Facebook sdk #3477

MichaelPetrinolis commented Apr 17, 2019

Jetski5822 commented Apr 18, 2019

MichaelPetrinolis commented Apr 18, 2019

agriffard commented Apr 26, 2019

MichaelPetrinolis commented Apr 26, 2019

sebastienros Apr 27, 2019

sebastienros Apr 27, 2019

sebastienros Apr 27, 2019

sebastienros commented Apr 27, 2019

agriffard commented Apr 29, 2019

sebastienros Jun 5, 2019

MichaelPetrinolis Jun 5, 2019

sebastienros Jun 5, 2019

sebastienros Jun 5, 2019

sebastienros Jun 5, 2019

sebastienros Jun 5, 2019

sebastienros Jun 5, 2019

sebastienros Jun 5, 2019

MichaelPetrinolis Jun 5, 2019

Add Facebook sdk #3477

Add Facebook sdk #3477

Conversation

MichaelPetrinolis commented Apr 17, 2019

Jetski5822 commented Apr 18, 2019

MichaelPetrinolis commented Apr 18, 2019

agriffard commented Apr 26, 2019

MichaelPetrinolis commented Apr 26, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebastienros commented Apr 27, 2019

agriffard commented Apr 29, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment