Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github auth #3493

Merged
merged 3 commits into from May 2, 2019

Conversation

Projects
None yet
4 participants
@MichaelPetrinolis
Copy link
Contributor

commented Apr 21, 2019

add github auth to the list of supported external providers

@agriffard

This comment has been minimized.

Copy link
Member

commented Apr 21, 2019

Thank you Michael.

@MichaelPetrinolis

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

Check it out when you get some time...

@agriffard

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

OK, I managed to:
Create an OAuth application on github
Enable the github authentication module
Set the client Id and Secret

Sign in with Github and link to an existing account

Enable registration
Register as another user with github

I am wondering a few things:
The association is only based on the username? The email is not retrieved from the github account when you register?
When you edit it in the admin, a user with external logins does not have any additional informations displayed?

@MichaelPetrinolis

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

  1. If a user tries to login with external provider, and registration is enabled then
  • If the external provider provides an email claim, we search for an existing account with that email
  • If not found, a new OC Account is created based on the username,email and password provided by the user
  • If found, we request the password of the OC Account in order to link the external login
    There is a PR that takes into consideration the email must confirmed parameter, if we request password in order to create a local Account from external login, and also uses the recaptcha
  1. There is a front page (OrchardCore.Users/Account/ExternalLogins) where you can link/unlink OC account with external providers. Of course, is not complete, we must decide how this is integrated with profile/account info in admin/front end

regarding the github, you must select to use your email in public and select which one of the verified emails will be included in the claims

@agriffard

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Fixes #3483

@@ -0,0 +1,24 @@
# Github (OrchardCore.Github)

This comment has been minimized.

Copy link
@sebastienros

sebastienros Apr 26, 2019

Member

Missing the entry in the main documentation index?

This comment has been minimized.

Copy link
@sebastienros

This comment has been minimized.

Copy link
@MichaelPetrinolis

MichaelPetrinolis May 2, 2019

Author Contributor

Didn't know how to do it. Found it in mkdocs.yml

@sebastienros sebastienros merged commit 7046bd7 into OrchardCMS:dev May 2, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla All CLA requirements met.
Details

@MichaelPetrinolis MichaelPetrinolis deleted the MichaelPetrinolis:github_auth branch May 10, 2019

/// </summary>
public class GithubSigninSettingsStep : IRecipeStepHandler
{
private readonly IGithubAuthenticationService _twitterLoginService;

This comment has been minimized.

Copy link
@Icidis

Icidis May 14, 2019

Contributor

Variable name does not match Interface and class <summary> is also incorrect.

This comment has been minimized.

Copy link
@Icidis

Icidis May 14, 2019

Contributor

Also the class should be changed to GithubSigninSettingsStep.cs

This comment has been minimized.

Copy link
@MichaelPetrinolis

MichaelPetrinolis May 14, 2019

Author Contributor

thanks @Icidis , the PR is already merged, so you can open a new one if you want to contribute, or tell me to do it.

Icidis added a commit to Icidis/OrchardCore that referenced this pull request May 14, 2019

@sebastienros sebastienros added this to the rc milestone May 20, 2019

sebastienros added a commit that referenced this pull request May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.