Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using strongly typed content type setting #4180

Merged
merged 1 commit into from Sep 9, 2019
Merged

Using strongly typed content type setting #4180

merged 1 commit into from Sep 9, 2019

Conversation

sebastienros
Copy link
Member

Fixes #1519

@deanmarcussen
Copy link
Member

deanmarcussen commented Sep 7, 2019 •
edited

Looks good, saw the same behaviour with boolean settings on #4166

The migrations / JSON automatically handles the conversion there so all good.

Let me know if you would like me to update the recipes with this change as well on #4166

Probably also for the other buildersContentTypePartDefinitionBuilder etc

@sebastienros sebastienros reopened this Sep 9, 2019
@sebastienros sebastienros merged commit 53596ba into dev Sep 9, 2019
@sebastienros sebastienros deleted the sebros/settings branch September 9, 2019 16:27
@sebastienros
Copy link
Member Author

It's merged now, so @deanmarcussen you can use booleans in the recipes if you feel like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent ContentDefinition and content recipe steps
2 participants
@sebastienros @deanmarcussen