Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Razor Pages import model state implementation for Forms module #4337

Merged
merged 1 commit into from Sep 20, 2019
Merged

Razor Pages import model state implementation for Forms module #4337

merged 1 commit into from Sep 20, 2019

Conversation

arkadiuszwojcik
Copy link
Contributor

Fix #4333

@dnfclas
Copy link

dnfclas commented Sep 19, 2019 •
edited

CLA assistant check
All CLA requirements met.

jtkech
jtkech approved these changes Sep 20, 2019
View reviewed changes
src/OrchardCore.Modules/OrchardCore.Forms/Filters/ImportModelStatePageFilter.cs
{
// Only Import if we are viewing.
if (context.Result is PageResult)
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay here, so i think we can remove this check in ImportModelStateAttribute.

@sebastienros sebastienros merged commit d2154da into OrchardCMS:dev Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtkech jtkech jtkech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forms: Standalone Razor Page and ModelState validation
4 participants
@arkadiuszwojcik @dnfclas @jtkech @sebastienros