Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ParseHeaders method #4773

Merged
merged 2 commits into from Nov 11, 2019
Merged

Updated ParseHeaders method #4773

merged 2 commits into from Nov 11, 2019

Conversation

@duncanhoggan
Copy link
Contributor

duncanhoggan commented Nov 11, 2019

Added Regex for headers allowing for multiple : characters in the value.

Added Regex for header slit allowing for multiple `:` characters
@sebastienros

This comment has been minimized.

Copy link
Member

sebastienros commented Nov 11, 2019

Please avoid regexes if possible. In this case add 2 as the second parameter of the Split method

Reverted the Regex solution to using the Split with a count argument set.
@duncanhoggan

This comment has been minimized.

Copy link
Contributor Author

duncanhoggan commented Nov 11, 2019

@sebastienros Updated, thanks for the amazing work you do in Orchard! Great to see it growing 🥳

@sebastienros sebastienros merged commit 826882d into OrchardCMS:dev Nov 11, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.