Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deployment plans unique #6804

Merged
merged 6 commits into from Aug 28, 2020
Merged

Conversation

deanmarcussen
Copy link
Member

Fixes #6774

Copy link
Member

@hishamco hishamco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after we ignore the casing

@agriffard
Copy link
Member

Build error:
DeploymentPlanController.cs(286,69): error CS1503: Argument 3: cannot convert from 'System.StringComparer' to 'System.StringComparison'

@agriffard
Copy link
Member

Test run is still failing after the change.

@deanmarcussen deanmarcussen reopened this Aug 28, 2020
@agriffard agriffard merged commit 20fcaf7 into dev Aug 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the deanmarcussen/deploymentplan-unicity branch August 28, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment plans should be unique by name
3 participants