Skip to content
Permalink
Browse files

Removing length limitation from IHostnameBinding.Aliases property

  • Loading branch information...
napernik committed Jul 16, 2019
1 parent b6bed91 commit c8787b3c41a382f286483fb23799bb0fb9a3c6d7
Showing with 1 addition and 1 deletion.
  1. +1 −1 Composite/Data/Types/IHostnameBinding.cs
@@ -48,7 +48,7 @@ public interface IHostnameBinding : IData
string PageNotFoundUrl { get; set; }

/// <exclude />
[StoreFieldType(PhysicalStoreFieldType.String, 512, IsNullable = true)]
[StoreFieldType(PhysicalStoreFieldType.LargeString)]
[ImmutableFieldId("{80C298F2-F493-465D-9F28-4F50DD0C03D5}")]
string Aliases { get; set; }

2 comments on commit c8787b3

@burningice2866

This comment has been minimized.

Copy link
Contributor

replied Jul 17, 2019

Isn't removing nullable problematic for existing IHostnameBinding records on SQL Server which risk failing while converting the column to not allow for null values?

@napernik

This comment has been minimized.

Copy link
Member Author

replied Jul 25, 2019

Thanks, fixed with a new commit.

Please sign in to comment.
You can’t perform that action at this time.