-
Notifications
You must be signed in to change notification settings - Fork 24
Gems without nokogiri cannot compile web docs #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
You should be able to bring in nokogiri yourself and those gems will work. I had a similar problem with my IAR plugin when I updated Origen versions and I included nokogiri in the application Gemfile to fix it. Origen doc helpers probably needs to be updated to pull in nokogiri itself since Origen no longer will. Or, we add nokogiri back to Origen's gemspec with just open conditions (no min/max version). |
Seems that if Origen doesn't actually need it though, just other things that depend on Origen need Nokogiri, then those other things should be pulling it in, not Origen itself. |
@coreyeng I don't think it is the gems responsibility because the web docs use some gem themselves right? Shouldn't that gem handle making sure it has nokogiri? |
Yes, you are correct. I was thinking the web filter stuff was in origen_doc_helpers, in which case, origen_doc_helpers should bring in Nokogiri. Doing a search on the origen repo, specs are also reliant on Nokogiri, so we should be bringing in Nokogiri in Origen (or ship this stuff out to other/separate plugins who will require nokogiri). |
I've noticed this too, it seems that Origen did actually depend on nokogiri. I think we should add nokogiri >= 1.7.2 into Origen's gemspec |
@info-rchitect okay to close this issue? |
Should be fixed in 0.33.1 |
@coreyeng yep |
Hi,
Here is the error:
I did a recursive grep and the only difference between gems that can compile web docs and those that cannot is the lack of nokogiri being in the Gemfile.lock.
The text was updated successfully, but these errors were encountered: