New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

origen test fails is user specifies where to install gems #261

Closed
info-rchitect opened this Issue Apr 30, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@info-rchitect
Member

info-rchitect commented Apr 30, 2018

  7) Origen.site_config Site config install directories with ENV variables set with ORIGEN_GEM_INSTALL_DIR set uses the value in ORIGEN_GEM_INSTALL_DIR instead of :gem_install_dir
     Failure/Error: expect(Origen.site_config.user_gem_dir).to eql("/env/gem/.origen/gems")
     
       expected: "/env/gem/.origen/gems"
            got: "/users/user/origen/.origen/gems"
     
       (compared using eql?)
     # ./spec/site_config_spec.rb:243:in `block (4 levels) in <top (required)>'
     # ./config/commands.rb:42:in `<top (required)>'
     # ./lib/origen/commands.rb:185:in `require'
     # ./lib/origen/commands.rb:185:in `<top (required)>'

When travis runs the same build it passes.

@coreyeng

This comment has been minimized.

Member

coreyeng commented Apr 30, 2018

Do you have any other Origen environment variables set? This is assuming a blank ENV and I think context restarts the process in specs, so it may be a spec bug where I need to clear the environment, not just the site config.

Travis wouldn't have ENV variables set, so it won't affect it there. I will try to replicate it.

@coreyeng coreyeng self-assigned this Apr 30, 2018

@coreyeng

This comment has been minimized.

Member

coreyeng commented Apr 30, 2018

To expand a bit, the context setup should override ORIGEN_GEM_INSTALL_DIRbut it won't clear ORIGEN_USER_GEM_DIR, so that may be throwing it off if you have it set.

If so, its a bug in the spec setup that I'll correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment