Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating rubocop ver to 0.54 and updating config files accordingly #370

Open
wants to merge 1 commit into
base: master
from

Conversation

@vbb9857
Copy link

vbb9857 commented Dec 3, 2019

No description provided.

@priyavadan

This comment has been minimized.

Copy link
Member

priyavadan commented Dec 3, 2019

@vbb9857 First PR! :) Good work!

@priyavadan priyavadan requested a review from ginty Dec 3, 2019
@info-rchitect

This comment has been minimized.

Copy link
Member

info-rchitect commented Dec 4, 2019

Nice work! 😁

@ginty

This comment has been minimized.

Copy link
Member

ginty commented Dec 4, 2019

Thanks a lot for doing this.

Could you take a look at the build fails below, click on details then from there the Ruby version to see the log of why it failed.
It looks like the origen lint command crashed.

Does it work locally for you?

@priyavadan

This comment has been minimized.

Copy link
Member

priyavadan commented Dec 5, 2019

Thanks a lot for doing this.

Could you take a look at the build fails below, click on details then from there the Ruby version to see the log of why it failed.
It looks like the origen lint command crashed.

Does it work locally for you?

@ginty seems like locally, no issues running "origen lint" , suggestions?

image

@info-rchitect

This comment has been minimized.

Copy link
Member

info-rchitect commented Dec 9, 2019

@vbb9857 Is there a reason you chose 0.54.0 vs the latest 0.77.0?

@vbb9857

This comment has been minimized.

Copy link
Author

vbb9857 commented Dec 10, 2019

@vbb9857 Is there a reason you chose 0.54.0 vs the latest 0.77.0?

Hi @info-rchitect, no apparent reason for choosing that ver. Is there any recommendation of what I should be using?

@info-rchitect

This comment has been minimized.

Copy link
Member

info-rchitect commented Dec 10, 2019

@vbb9857 Is there a reason you chose 0.54.0 vs the latest 0.77.0?

Hi @info-rchitect, no apparent reason for choosing that ver. Is there any recommendation of what I should be using?

I think people usually use the latest unless there is Ruby version conflict or a gem dependency conflict.

@info-rchitect

This comment has been minimized.

Copy link
Member

info-rchitect commented Dec 16, 2019

Does anyone object to moving to the latest version of rubocop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.