Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Localize <Timelapse> component #248

Closed
jordajm opened this issue Jun 2, 2018 · 2 comments
Closed

Localize <Timelapse> component #248

jordajm opened this issue Jun 2, 2018 · 2 comments
Assignees
@jordajm
Labels
enhancement New feature or request javascript ui/ux

Comments

@jordajm
Copy link
Contributor

jordajm commented Jun 2, 2018 •
edited
Loading

Sub-task of: #238

The <Timelapse> component is used to say how long ago an event occurred.

It is currently english-only and needs to be internationalized.

One possible strategy may be to use moment-locale in addition to or instead of the standard moment library, but more research is required.
@jordajm jordajm self-assigned this Jun 2, 2018
@micahalcorn micahalcorn added enhancement New feature or request ui/ux javascript labels Jun 2, 2018
@micahalcorn
Copy link
Member

micahalcorn commented Jun 2, 2018 •
edited
Loading

Another concern here is that the designs call for abbreviated versions. It's one thing to convert "5 days ago" into another language. But does "5d" translate?

@wanderingstan wanderingstan mentioned this issue Jun 2, 2018
Closed
6 tasks
jordajm added a commit that referenced this issue Jun 8, 2018
@jordajm
Issue #248 - Translate country options
eb39522
micahalcorn pushed a commit that referenced this issue Jun 8, 2018
@jordajm @micahalcorn
Issue #249 - Wrapping the remaining strings in <FormattedMessage> com…
ca409e8 
…ponent (#252)

* Issue #249 - FormattedMessage wrappers for web3-provider.js

* Issue #249 - Wrapping strings in <FormattedMessage> components

* Issue #249 - translation JSON updates

* Issue #249 - Generating new all-messages.po

* Issue #249 - Add back message-context flag to translate:build-source script

* Issue #249 - Update machine translations of Chinese

* Issue #249 - fixing some issues Micah found

* Issue #249 - Adding missing curly braces in notification.js

* Translate listing card badge

* Translate perspective badges

* Repair counterparty names

* Issue #249 - Localization of purchase-detail.js

* Issue #249 - remove test language const

* Issue #249 - Wrap all Unnamed User strings

* Issue #249 - Wrapping strings in connectivity.js

* Issue #249 - Wrap strings in notifications.js

* Issue #249 - Wrap strings in user.js

* Issue #248 - Translate country options

* Issue #249 - update machine translations

* Issue #249 - updating translations again

* Issue #249 - Wrapping one more heading string
jordajm added a commit that referenced this issue Jun 16, 2018
@jordajm
Issue #248 - Use moment with locale instead of roll-your-own timelapse
099b85d
jordajm added a commit that referenced this issue Jun 17, 2018
@jordajm
Issue #248 - Update "time ago" messages every 30 seconds
f0a4955
micahalcorn pushed a commit that referenced this issue Jun 25, 2018
@jordajm @micahalcorn
Issue #248 - replace <timelapse> component with locale-aware moment.js (
b47c89b 
#271)

* Issue #248 - Use moment with locale instead of roll-your-own timelapse

* Issue #248 - Update "time ago" messages every 30 seconds

* Only using intervals where we need them

* Change element type to avoid unnecessary spans
@micahalcorn
Copy link
Member

No longer necessary thanks to #271 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jordajm jordajm

Labels
enhancement New feature or request javascript ui/ux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@micahalcorn @jordajm