Conversation
Deep linking to webview would be very helpful. 🙏 |
This is ready to go, some other changes:
|
…tocol/origin into tomlinton/mobile-notifications
@wanderingstan did you want to take a look at this? If not, I'll probably just stamp it. 🤷♂ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all LGTM, but I'm not set up to test it. @tomlinton can we schedule some time tomorrow? I'd also like to get up to speed for integrating user-to-user messaging. (Though I think I see how we'd do it)
Sure, whatever suits. Can do anything after 1pm your time. This is a real hassle to test locally, you need to have a working docker-compose stack and an iOS/Android build running on a physical device (simulators don't support push notifications) and figure out how to connect to a DApp running on your machine over wifi. And you also need proper development APNS/FCM credentials. 😞 I think if we just push it to dev and use TestFlight builds to pick up any bugs I didn't find in my own testing it will be the easiest. |
This is a draft of the mobile push integration with the new notifications server. Check it out @wanderingstan and we can sync up.
Things I have to do:
Closes #2049 and closes #1879.