Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CICD updates around packing/pushing NuGet packages #13

Merged
merged 6 commits into from
Nov 24, 2021
Merged

CICD updates around packing/pushing NuGet packages #13

merged 6 commits into from
Nov 24, 2021

Conversation

Kritner
Copy link
Member

@Kritner Kritner commented Nov 24, 2021 •
edited
Loading

  • Updates CICD action with explicit nuget pack/push steps, as the action that was being used had some behaviors that weren't working as expected.
  • Updates CICD action to only push packages from branches main, and RELEASE/v*

Closes #11, closes #9.

@Kritner
Removes the (no longer used) variable OrleansSyncWorkVersion from D…
1097886 
…irectory.Build.props

* Closes #11
@Kritner
Updates CICD with NuGet push through CLI
5a80ace 
* Updates Nbgv version to include the "-prerelease" tag, I expect this to be dropped when `prepare-release` is invoked from `nbgv`
* Partially addresses #9
@Kritner
Correct nesting (I think) on github action for CICD
d4113ad
@Kritner
Adds release configuration to build steps within CICD
58187b5
@Kritner
CICD --c -> -c, invalid switch
ac2e31b 
* had it `--configuration`, changed to `--c` to make it more like the other steps in the action, failing to make it `-c` instead.  whoops.
* https://github.com/Kritner/Orleans.SyncWork/runs/4314317577?check_suite_focus=true
@Kritner
Updates current NuGet package version in version.json
a2fc502 
* Updates CICD to only fire on pushes to main and RELEASE/*
@Kritner Kritner merged commit 7a0378c into main Nov 24, 2021
@Kritner Kritner deleted the FEATURE/cicd branch November 24, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove package variable from Directory.Build.props CICD not working quite as intended
1 participant
@Kritner