New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No CPU/Memory info in with 2.0.1 #122

Closed
dandago opened this Issue Apr 11, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@dandago

dandago commented Apr 11, 2018

Not sure if this is a problem at all, but in the two or three quick samples I built with Orleans 2.0 and the new dashboard over the past few days, I noticed I never had memory or CPU information for the silo.

See this screenshot as an example.

I was running using localhost configuration, so not sure if this or any other factors may have affected it.

I'm just raising it in case it needs further inspection.

@SebastianStehle

This comment has been minimized.

Contributor

SebastianStehle commented Apr 11, 2018

CPU and Memory metrics are only enabled on Windows when you add the Microsoft.Orleans.OrleansTelemetryConsumers.Counters package. You also have to wait some time, before you can see it.

@dandago

This comment has been minimized.

dandago commented Apr 12, 2018

Oh! Good to know!

@SebastianStehle

This comment has been minimized.

Contributor

SebastianStehle commented Apr 13, 2018

Can I close the issue?

@dandago

This comment has been minimized.

dandago commented Apr 13, 2018

Yes, though I think this should go in the readme. If it's not documented, people are going to be wondering like me.

@SebastianStehle

This comment has been minimized.

Contributor

SebastianStehle commented Apr 13, 2018

Can you make a PR? ;)

Btw: this is not specific to the dashboard, it is the orleans implementation. There is not "common" way to retrieve these information for all operation systems.

@dandago

This comment has been minimized.

dandago commented Apr 28, 2018

Sorry for the late reply - I've been really busy.

Can you make a PR? ;)

I'm afraid I don't have time at this stage. This is a one-liner change and it would take me a lot more time just to go through all the git stuff to do this. It's a lot easier for an existing contributor.

If this remains open for a while, maybe I can give it a shot in a few weeks.

Btw: this is not specific to the dashboard, it is the orleans implementation. There is not "common" way to retrieve these information for all operation systems.

Yes, but given that the dashboard is based on Orleans, any Orleans-related dependencies should be documented.

Otherwise there will just be a lot of people like me scratching their heads and opening issues on GitHub.

@richorama richorama closed this in 5b2fc74 Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment