-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not able to estimate from scRNAseq package #82
Comments
Ok, I was able to estimate params using this: > counts <- (assay(allen))
> params <- splatEstimate(counts)
<simpleError in optim(par = vstart, fn = fnobj, fix.arg = fix.arg, obs = data, gr = gradient, pdistnam = pdistname, hessian = TRUE, method = meth, lower = lower, upper = upper, ...): non-finite finite-difference value [2]> The Also, is |
Hi @asifzubair The first error is because this dataset doesn't have anything in the The |
Yes, it is kinda odd that the |
Hi @lazappi Thank you for addressing this issue in the codebase. Also, I was wondering if you have any suggestions on how to pick appropriate Thank you, Asif |
If you have a dataset with known groups in it you can perform a differential expression analysis between two groups and fit a log-normal distribution to the foldchange (not log-foldchange) estimates. This is approximately what Splat is trying to simulate. I usually use the |
Hi @lazappi - would you recommend fitting the log-normal to the FC between two groups or between one group and the rest? Also - I just wanted your thoughts on this: recently, in the CellAssign paper they claimed that the splatter model needs to be augmented because it doesn't model logFC well in all cases. They have some very (draft) experiments to demonstrate this here. Do you think their claims hold water and that perhaps the augmented model should be incorporated into splatter? Thanks! |
The generated factors are relative to a fictional base cell so I think fitting one group compared to everything else would be closest to that. This is a very approximate process though so I'm not sure it would make too much difference. Thanks for letting me know about the comments in the CellAssign paper! 😸 I hadn't seen those before. I haven't looked at it in a lot of detail but it is definitely possibly that another distribution is a better fit. It's definitely something to consider adding as an option to the Splat model. |
I'm trying to estimate parameters from datasets available in the scRNAseq package. Since these datasets are already of type
SingleCellExperiment
,I thought I should be able to do something like this:
However, I get an error when I do that:
Any ideas on what's going on and how to fix it ?
Thanks!
The text was updated successfully, but these errors were encountered: