Skip to content
This repository has been archived by the owner on Dec 8, 2023. It is now read-only.

fix(packaging): use zip_safe=False #29

Merged
merged 1 commit into from Oct 8, 2018
Merged

fix(packaging): use zip_safe=False #29

merged 1 commit into from Oct 8, 2018

Conversation

peppsac
Copy link
Contributor

@peppsac peppsac commented Oct 5, 2018

Numba caching strategy seems to be incompatible with zip storage of source files.
Using zip_safe=False fix this problem.

Fixes #25

@peppsac
fix(packaging): use zip_safe=False
e0bf87d 
Numba caching strategy seems to be incompatible with zip storage of source files.
Using zip_safe=False fix this problem.

Fixes #25
@peppsac peppsac requested a review from ldgeo October 5, 2018 15:27
@peppsac peppsac mentioned this pull request Oct 5, 2018
Closed
ldgeo
ldgeo approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@ldgeo ldgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, according to the setuptools doc, it consider the project unsafe (setting the zip_flag to False) only if it contains any C extensions or datafiles. Not the case with numba decorators. Good to know.

@peppsac peppsac merged commit b6f6848 into master Oct 8, 2018
@peppsac peppsac deleted the fix_issue_25 branch October 8, 2018 07:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ldgeo ldgeo ldgeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run the tests nor the samples.
2 participants
@peppsac @ldgeo